Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UserTest #2135

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Fix UserTest #2135

merged 2 commits into from
Nov 8, 2024

Conversation

labkey-adam
Copy link
Contributor

Rationale

Expected error message changed. Stashing the userId for later use from doSetup() does not work.

Related Pull Requests

@labkey-adam
Copy link
Contributor Author

@labkey-tchad @labkey-danield is there a good way to stash the userId at user creation time? Sticking it in a member var doesn't work... the infrastructure must toss the test instance after doSetup() is called.

@labkey-tchad
Copy link
Member

@labkey-tchad @labkey-danield is there a good way to stash the userId at user creation time? Sticking it in a member var doesn't work... the infrastructure must toss the test instance after doSetup() is called.

You could make _normalUserId static

@labkey-adam
Copy link
Contributor Author

@labkey-tchad @labkey-danield is there a good way to stash the userId at user creation time? Sticking it in a member var doesn't work... the infrastructure must toss the test instance after doSetup() is called.

You could make _normalUserId static

Sure... as long as we never plan to run tests in parallel in the same VM

@labkey-adam labkey-adam merged commit 70181d4 into release24.11-SNAPSHOT Nov 8, 2024
4 checks passed
@labkey-adam labkey-adam deleted the 24.11_fb_usertest branch November 8, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants