try to prevent stale reference to textarea #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-danield
requested changes
Aug 28, 2023
There was a problem hiding this comment.
Cannot assume all delete dialogs will have a text area.
Examples of failures in LKSM with this change.
| @@ -41,6 +41,7 @@ protected DeleteConfirmationDialog(ModalDialogFinder finder, SourcePage sourcePa | |||
| protected void waitForReady() | |||
| { | |||
| WebDriverWrapper.waitFor(()-> elementCache().body.isDisplayed() && | |||
| Locator.tagWithClass("textarea", "form-control").existsIn(this) && | |||
There was a problem hiding this comment.
This assumes all delete dialogs will have a text are, that is not true.
labkey-danield
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Recently, BiologicsAdminTest.testDeleteEmptyProject began failing on lims_starter with an error saying that the user-comment textArea was stale.
I've recently observed modal dialog-derived components failing in the same way and it seems that awaiting the component to be ready is helpful- it's possible that the component's lifecycle requires us to wait more rigorously, or to just use refindingElements within it.
Related Pull Requests
n/a
Changes