align table cell text helper to new UI #1614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
requested review from
labkey-tchad,
labkey-matthewb and
labkey-danield
|
I'm not sure what's happening here or if someone rebased testAutomation somehow, but my feature branch with fixes somehow pull in changes I haven't made and result in a non-compiling build 🙄 |
|
OK, attempting to manually revert the changes that weren't intentional |
|
Yes, I talked to @labkey-matthewb about it, he thought it would be right to update this helper. It was part of the work to remove inline markup, probably not surprising to see it not affecting everything else |
labkey-tchad
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Recent changes to remove inline markup elements caused the finder for a non-dataregion table to fail because the locator looking for it expected its dataregion title element to be wrapped in a //div/h3/a/span, but is now in a //div/h3/span/span. I've taken the liberty to make the locator a little more robust to UI changes like this in the future
Related Pull Requests
n/a
Changes