wait for comment text area to exist before interacting #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Recently tests have been observed to fail while interacting with a DeleteConfirmationDialog because framework code assumes the comment textArea element will be present and interactable. Artifacts show it to be absent, a loading spinner being shown.
This causes DeleteConfirmationDialog to wait for its body element to be displayed, and for the dialog to not contain a loading spinner, and it now waits for up to a second for the comment textarea to be present, hopefully that will prevent test noise/uninteresting failures
Related Pull Requests
n/a
Changes