Skip to content

Commit

Permalink
Improve type computation when creating new metadata domain properties (
Browse files Browse the repository at this point in the history
  • Loading branch information
labkey-klum authored Aug 31, 2023
1 parent 0d7fe57 commit 800e57c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions data/GPAT/plate-metadata-1.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
"negative" : {"dilution": 1.01}
},
"sample" : {
"SA01" : {"dilution": 1.01, "ID" : 111, "Barcode" : "BC_111", "Concentration" : 0.0125},
"SA02" : {"dilution": 2.01, "ID" : 222, "Barcode" : "BC_222"},
"SA03" : {"dilution": 3.01, "ID" : 333, "Barcode" : "BC_333"},
"SA04" : {"dilution": 4.01, "ID" : 444, "Barcode" : "BC_444"}
"SA01" : {"dilution": 1.00, "ID" : 111, "Barcode" : "BC_111", "Concentration" : 0.0125},
"SA02" : {"dilution": 2.00, "ID" : 222, "Barcode" : "BC_222"},
"SA03" : {"dilution": 3.00, "ID" : 333, "Barcode" : "BC_333"},
"SA04" : {"dilution": 4.00, "ID" : 444, "Barcode" : "BC_444"}
}
}
2 changes: 1 addition & 1 deletion src/org/labkey/test/tests/GpatPlateTemplateTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public void testWithPlateTemplateAndPlateMetadata()
table.getColumnDataAsText("PlateData/sample_well_groups"));
checker().verifyEquals("Barcode is incorrect", Arrays.asList("BC_111", "BC_111", "BC_111", "BC_222", "BC_222", "BC_222", "BC_333", "BC_333", "BC_444", "BC_444"),
table.getColumnDataAsText("PlateData/Barcode"));
checker().verifyEquals("Dilution is incorrect", Arrays.asList("1.01", "1.01", "1.01", "2.01", "2.01", "2.01", "3.01", "3.01", "4.01", "4.01"),
checker().verifyEquals("Dilution is incorrect", Arrays.asList("1.0", "1.0", "1.0", "2.0", "2.0", "2.0", "3.0", "3.0", "4.0", "4.0"),
table.getColumnDataAsText(" PlateData/dilution"));
checker().screenShotIfNewError("rowsOutsideControlWells");
table.clearAllFilters();
Expand Down

0 comments on commit 800e57c

Please sign in to comment.