Schema update and fix #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
spamhurts
commented
Sep 13, 2023
spamhurts
commented
- Fixed data type for defaultValue in PackageAttributeTable.java
- Added sortOrder column to EventData - Java class, SQL, and XML
- Added sortOrder column to SNDTest.java
- Updated module version to 23.004
- Added sortOrder column to SNDTest.java
RameshRapa
reviewed
Sep 13, 2023
RameshRapa
approved these changes
Sep 14, 2023
jallentxbiomed
added a commit
that referenced
this pull request
Oct 19, 2023
* Increased default value of EventDataId in SNDSequencer (#131) * removed unnecessary loop over eventIds * refactored narrative cache code for optimization * changed subpackage query * changed subpackage query * Schema update and fix (#144) * Fixed defaultValue data type in PackageAttributeTable.java * - Added sortOrder column to Java class, SQL, and XML - Added sortOrder column to SNDTest.java * - Added additional exception handling in parseEventData() * Increased default value of EventDataId in SNDSequencer (#131) * removed unnecessary loop over eventIds * refactored narrative cache code for optimization * changed subpackage query * changes * added subpackages to narratives * added sorting to subpackages * New superPackages database function (#148) * - Added database function to return a list of fully expanded superpackages - fixed JSONObject getter error - updated module to 23.005 * - removed file with bad encoding * - Added static reference for fGetAllSuperPkgs in SNDSchema.java - re-added snd-23.004-23.005.sql * Increased default value of EventDataId in SNDSequencer (#131) * removed unnecessary loop over eventIds * refactored narrative cache code for optimization * changed subpackage query * changes * added subpackages to narratives * added sorting to subpackages * Increased default value of EventDataId in SNDSequencer (#131) * refactored narrative cache code for optimization * added styling * cached childSuperPackages * cached childSuperPackages * fixed failing event test * reverted formatting * reverted formatting * - Changed accessor methods for JSON data (attribute data) --------- Co-authored-by: Terry J Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.