add additivity=false to prevent double logging

[labkey-willm]

Rationale

the block at the start of the Loggers could cause the subsequent calls to create double logs. Setting additivity="false" will prevent that.

https://logging.apache.org/log4j/2.x/manual/configuration.html#Additivity

Related Pull Requests

• add additivity="false" where missing to prevent double logs Dockerfile#97
• https://github.com/LabKey/syseng-chef-server/pull/537

Changes

[labkey-adam]

I'm not an additivity expert by any means, but are you sure these parameters are needed here? My reading of the docs says this is useful only when a Logger element specifies an appender and we want its logging to go to just that appender (not the root as well). Most of these Logger elements don't specify an appender. They are present to provide the option (typically during development) of lowering the logging level for specific packages OR to raise the level for noisy third-party libraries. I don't see why we'd need additivity for these.

[labkey-adam]

There are only three Logger elements here that specify an appender; I'll comment directly on those lines.

[labkey-adam]

See comments

[labkey-adam]

I see now that a couple of these additivity parameters were already present (not added in this PR). Comments still hold, though... additivity plus CONSOLE appender seems unnecessary.

[labkey-adam]

I'm not an additivity expert by any means, but are you sure these parameters are needed here? My reading of the docs says this is useful only when a Logger element specifies an appender and we want its logging to go to just that appender (not the root as well). Most of these Logger elements don't specify an appender. They are present to provide the option (typically during development) of lowering the logging level for specific packages OR to raise the level for noisy third-party libraries. I don't see why we'd need additivity for these.

This is the very first scenario cited on the doc page as an example where additivity is not needed: https://logging.apache.org/log4j/2.x/manual/configuration.html#Additivity

[labkey-willm]

I'm not an additivity expert by any means, but are you sure these parameters are needed here? My reading of the docs says this is useful only when a Logger element specifies an appender and we want its logging to go to just that appender (not the root as well). Most of these Logger elements don't specify an appender. They are present to provide the option (typically during development) of lowering the logging level for specific packages OR to raise the level for noisy third-party libraries. I don't see why we'd need additivity for these.

This is the very first scenario cited on the doc page as an example where additivity is not needed: https://logging.apache.org/log4j/2.x/manual/configuration.html#Additivity

yes, you're quite right, and this confirms what we just found with the chef version, is that having additivity=false on loggers w/o specific appenders results in no logs at all for that logger. I'll fix things up.

[labkey-adam]

A couple remaining tweaks