CalculateCurveFitAction and support for 3PL curve fit #6053
+362
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quare error, R2, adjusted R2
labkey-klum
reviewed
Nov 14, 2024
labkey-klum
reviewed
Nov 14, 2024
| } | ||
|
|
||
| @Override | ||
| public CurveFit getCurveFit(CurveFitType type, DoublePoint[] data, @Nullable Double asymptoteMin, @Nullable Double asymptoteMax) | ||
| { | ||
| switch (type) | ||
| { |
There was a problem hiding this comment.
Is the plan to keep both 3 Parameter variants, or are we waiting for feedback from the client? Unless there is a good reason to keep both, it feels like having a single fit function might be less confusing.
There was a problem hiding this comment.
I'm not entirely sure yet. I was thinking of keeping them both around for now (similar to how we currently have 2 variants of 4PL curve fits). Then when we get to the actually plotting story to implement the selection of the curve fit type, we can make the final call at that time and either: 1) only show a subset of the options in the plotting UI or 2) remove the 3PL option we don't want.
labkey-klum
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We will be adding support for including a curve fit line in the chart wizard. This set of PRs are the first step: adding an API to request a curve fit for a set of data points. The API uses our existing curve fit types along with the new 3PL fit type. The response includes the curve fit parameters for the requested fit type, the stats for the fit, and generated data points to use for plotting (optional).
Related Pull Requests
Changes