Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderIconAndFilename() expects actual path #6052

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

labkey-matthewb
Copy link
Contributor

Rationale

renderIconAndFilename() expects actual path
belt and suspenders fix for !f.exists()

Related Pull Requests

Changes

belt and suspenders fix for !f.exists()
Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks OK but there appear to be tests expecting different results.

@labkey-matthewb labkey-matthewb merged commit 7c4c78c into release24.11-SNAPSHOT Nov 14, 2024
2 checks passed
@labkey-matthewb labkey-matthewb deleted the 24.11_fb_filelink_notexists branch November 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants