Support all labkey.xml/ROOT.xml settings via application.properties #5142
Conversation
| String path = getContextPath(); | ||
|
|
||
| return "".equals(path) ? "ROOT.xml" : path.substring(1) + ".xml"; | ||
| return "application.properties"; |
There was a problem hiding this comment.
Is this overridden somewhere so we can still return the .xml files? I think the tomcat10 branch will get merged before we are able to all be using embedded all the time.
There was a problem hiding this comment.
No, it's now hard-coded to always return application.properties. I could do work to be able to differentiate between standalone and embedded Tomcat, but for the moment I'm proceeding optimistically that by 24.3 on-premise deployments (where users are most likely to see these messages) will all be configured via the properties file. If you think that's a bad idea, let me know
There was a problem hiding this comment.
Seems OK (now that I've looked at what this method actually does) and easy enough to rework if need be.
Rationale
We're enabling full compatibility for configuration via embedded Tomcat.
Changes