Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nonce to tracking script template #5122

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

labkey-tchad
Copy link
Member

Rationale

Tracking scripts are triggering our new content security policy. They need the nonce.

Related Pull Requests

Changes

  • Add nonce to Google analytics tracking script template
  • Add instructions for adding nonce to custom tracking scripts

Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me, but I'm no expert. I defer to Matt on approval here.

@labkey-willm
Copy link
Contributor

Seems right to me, but I'm no expert. I defer to Matt on approval here.

same.

@labkey-tchad labkey-tchad merged commit 21aff3f into release24.1-SNAPSHOT Jan 12, 2024
4 of 7 checks passed
@labkey-tchad labkey-tchad deleted the 24.1_fb_analyticsNonce branch January 12, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants