Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update project assignment ETL trigger #396

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Update project assignment ETL trigger #396

merged 5 commits into from
Oct 15, 2024

Conversation

labkey-martyp
Copy link
Contributor

@labkey-martyp labkey-martyp commented Sep 23, 2024 •
edited
Loading

Rationale

In project assignment, strip off animal Id at end of project (if it exists) and use the rest of the project name to do an exact match on project.

Changes

  • Update assignment.js BEFORE_INSERT
  • Update project and assignment ETL source queries

labkey-bpatel
labkey-bpatel approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@labkey-bpatel labkey-bpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! As per our discussion block starting line 65, if (!projectId)... now seems redundant.

@labkey-martyp labkey-martyp merged commit d65811f into release24.7-SNAPSHOT Oct 15, 2024
1 check was pending
@labkey-martyp labkey-martyp deleted the 24.7_fb_project_etl_fix branch October 15, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankurjuneja ankurjuneja ankurjuneja approved these changes

@labkey-bpatel labkey-bpatel labkey-bpatel approved these changes

@NIRC-IT NIRC-IT Awaiting requested review from NIRC-IT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@labkey-martyp @labkey-bpatel @ankurjuneja