Update configurations for node
plugin to use a single version of binaries; remove yarn configurations
#226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Our default configuration for modules using npm is to have each module act independently, using its own downloaded version of node and npm. We have a good number of modules using npm, so this leads to our having lots of redundant copies of these binaries in play while developing. We recently removed support for standalone module building, so there is no real compelling case for the current default configuration. We've also recently seen builds failing when trying to download the binaries for some of the modules that are built later in the build process. Though we don't know that it is because of our downloading the binaries multiple times, we also don't know that that isn't the cause.
This PR changes our default configuration for the
npmSetup
task to have only the:server
project do the downloading, stashing the binaries under the.node
directory. Other modules are configured with this download directory as their work directory for bothnode
andnpm
. If any modules need to be differently configured (with a different version of node or a different working directory), they can still do so by setting up their own configuration of thenpm
extension.We also remove the configurations related to
yarn
tasks since we do not anticipate having any projects usingyarn
.Related Pull Requests
Changes
npm
pluginyarn
.nodeModulesDir
tonodeProjectDir
for latest version of node plugin.