Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configurations for node plugin to use a single version of binaries; remove yarn configurations #226

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

labkey-susanh
Copy link
Contributor

Rationale

Our default configuration for modules using npm is to have each module act independently, using its own downloaded version of node and npm. We have a good number of modules using npm, so this leads to our having lots of redundant copies of these binaries in play while developing. We recently removed support for standalone module building, so there is no real compelling case for the current default configuration. We've also recently seen builds failing when trying to download the binaries for some of the modules that are built later in the build process. Though we don't know that it is because of our downloading the binaries multiple times, we also don't know that that isn't the cause.

This PR changes our default configuration for the npmSetup task to have only the :server project do the downloading, stashing the binaries under the .node directory. Other modules are configured with this download directory as their work directory for both node and npm. If any modules need to be differently configured (with a different version of node or a different working directory), they can still do so by setting up their own configuration of the npm extension.

We also remove the configurations related to yarn tasks since we do not anticipate having any projects using yarn.

Related Pull Requests

Changes

  • Update default configuration for npm plugin
  • Remove configuration code related to yarn.
  • Update from nodeModulesDir to nodeProjectDir for latest version of node plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant