Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FCS_FILENAME correction #123

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Conversation

jryurkanin
Copy link
Contributor

Rationale

ticket

  • client requested that all their queries use the $FCS parameter for the FCS_FILENAME field. This was originally not occurring in some instances because the $FCS may be an integer, which causes labkey to display the next field in the A._well lookup instead of the $FCS parameter value.

Related Pull Requests

Changes

@jryurkanin jryurkanin changed the title Update AnalysisPlan060.sql FCS_FILENAME correction Aug 30, 2023
@jryurkanin
Copy link
Contributor Author

@labkey-jony Steve asked me to implement the change in AP060 to all his AP queries. Before I do that, can you take a look at the SQL and let me know if I should be doing it differently? Seems simple enough, but I want to check before spending a while changing all 60 queries.

Realistically, this change only needs to be applied to a subset of his queries, but I would rather his AP queries uniformly define the FCS_FILENAME field.

@jryurkanin
Copy link
Contributor Author

I decided to just update a few key APs that Steve mentioned.

@labkey-jony
Copy link
Contributor

I added @labkey-matthewb to the reviewers since he would know for sure.

The changes look okay to me, but this is something completely new for me, so I'm not the right person to put a stamp of approval on this. But if Steve managed to test it out and confirm things, I think that's good enough.

@jryurkanin
Copy link
Contributor Author

josh took a look at it and thought it was okay too. there are edge-case scenarios that could cause problems, but they are highly improbable.

@jryurkanin jryurkanin merged commit 4331305 into release23.7-SNAPSHOT Sep 5, 2023
1 check passed
@jryurkanin jryurkanin deleted the 23.7_fb_FCS_FILENAME_fix branch September 5, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants