Backport the latest Active filters and other updates to 24.1 #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e Filters (#621) * Modify 'Active Filters' section with buttons reorganized, labeled differently, and styled. * Display Group Save panel in the Active Filters area upon clicking 'Save as a group' button. * Group save buttons * Implement Group Edit workflow * Handle button and view stages during Save and Edit workflow * Tie in already saved filters to the new workflow (i.e. display Edit button upon filter display, etc.) * Handle Edit > Update * Handle race condition when a user is on Group details page, and we edit or create a new group from that point on (wip). * Hide edit button when there is an error * Use saveParticipantGroup.api instead of updateParticipantGroup.api for edit/updates * Fix Home page groups' View all link * Styling updates and cleanup * Add MAb to Learn Groups and update selectRowItem if MAb. * Update MAb group save * Add id for identifying components for debugging. * Fix for Group selection - having a custom 'id' and doLayout() (which updates the layout upon item select) doesn't belong together, Ext needs to generate its own ids to be able to do the layout upon different Group selections. * Clear filter upon group delete, test updates. * Test updates/fixes with comments * Client requested updates - Make error msg cds user friendly, add red border to the errored input box. Don't display group details page upon save, customize Group label in the Filter pane to have 'cds' red color and with a hyperlink to the groupsummary/details page.
labkey-bpatel
changed the title
labkey-klum
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Backport below PRs to 24.1 so that production upgrade to 24.1 has the latest features and fixes.
Related Pull Requests
Changes