Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert new ciphers #82

Closed

Conversation

labkey-willm
Copy link
Contributor

@labkey-willm labkey-willm commented Mar 22, 2024

Rationale

ciphers added in #73 work fine locally but are incompatible with older AWS ALB security policies. More testing is required.

This will throw a scary but benign error in the logs:

lims_starter  | WARNING: Tomcat interprets the [ciphers] attribute in a manner consistent with the latest OpenSSL development branch. Some of the specified [ciphers] are not supported by the configured SSL engine for this connector (which may use JSSE or an older OpenSSL version) and have been skipped: [[TLS_ECDHE_ECDSA_WITH_AES_256_CCM, TLS_DHE_PSK_WITH_AES_256_CCM, TLS_DHE_RSA_WITH_AES_256_CCM, TLS_ECDHE_PSK_WITH_AES_256_CBC_SHA384, 
...

Related Pull Requests

Changes

  • revert cipher to old list
  • fix dockle workflow to rename HelloWorld jar to just labkeyServer.jar for test build

Copy link

ERROR: A pull request from 24.3_fb_24.3_revert_ciphers is expected to target release24.3-SNAPSHOT, not release24.3
Note: Pull requests should not target non-snapshot release branches directly.

@labkey-willm labkey-willm changed the base branch from release24.3 to release24.3-SNAPSHOT March 22, 2024 20:30
@labkey-willm
Copy link
Contributor Author

new one w/o dev updates: #83

@labkey-tchad labkey-tchad deleted the 24.3_fb_24.3_revert_ciphers branch July 2, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants