add datadog java tracer and APM options #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-willm
requested review from
labkey-stuartm
and removed request for
labkey-stuartm
labkey-willm
force-pushed
the
fb_enable_dd_apm
branch
from
f2e0373
to
296e237
Compare
labkey-stuartm
approved these changes
Aug 30, 2023
labkey-jeckels
approved these changes
Aug 31, 2023
| @@ -205,6 +205,10 @@ RUN mkdir -p /usr/src/awsclizip "${LABKEY_HOME}/awsclibin" "${LABKEY_HOME}/aws-c | |||
| && rm -rf /usr/src/awsclizip \ | |||
| && chown -R labkey:labkey "${LABKEY_HOME}/awsclibin" "${LABKEY_HOME}/aws-cli" | |||
|
|
|||
| # install datadog tracing agent | |||
| RUN mkdir -p datadog \ | |||
| && wget -q -O datadog/dd-java-agent.jar https://dtdg.co/latest-java-tracer | |||
There was a problem hiding this comment.
Do we want to pin this to a particular version or always grab that latest? I know we generally want to stay current, but sometimes it's painful to not have more explicit control.
There was a problem hiding this comment.
We've been allowing cloud deployments to always pull the latest version of the main datadog agent and tracer for most of a year without an issue. I feel like their dev/release processes are very robust and would rather take that risk than have one more thing to version bump. If it broke it would probably fail the teamcity build anyway (if we enable all the datadog features in the build job, which seems prudent).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dd-java-agent.jar to the image, but only adds it to the final java command line if DD_COLLECT_APM==true.
Also comments out several duplicate CONSOLE outputs.