Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable optional JSON logging to console #42

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Conversation

labkey-willm
Copy link
Contributor

@labkey-willm labkey-willm commented Aug 28, 2023

This adds two new optional env vars:

  • LOG4J_CONFIG_FILE: uses the included local log4j2.xml by default, but can be set to alternates (if they exist wlin the image, like server/labkeywebapp/WEB-INF/classes/log4j2.xml for the default embedded file)
  • JSON_OUTPUT: false by default to maintain existing functionality, but can be set to true to output all java logs as JSON; tomcat and access logs are still non-JSON for now

This also updates the default log4j2.xml to more closely match the current default 'server' version.

Copy link
Contributor

@labkey-jeckels labkey-jeckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I take it that you want the non-JSON HTTP access logs for now?

@labkey-willm
Copy link
Contributor Author

I take it that you want the non-JSON HTTP access logs for now?

Yeah, it's fine for now. I'll circle back to make matching changes to Dockerfile's application.properties once the json access log bits are available in the server.

@labkey-willm labkey-willm merged commit 978713b into develop Aug 28, 2023
4 checks passed
@labkey-willm labkey-willm deleted the fb_dd_integ branch August 28, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants