Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix various AudioFileProcessor bugs #7533

Merged
merged 7 commits into from
Oct 6, 2024
Merged

fix various AudioFileProcessor bugs #7533

merged 7 commits into from
Oct 6, 2024

Commits on Oct 3, 2024

  1. fix out-of-bounds crash in AudioFileProcessor 

    by correctly setting m_from and m_to without them interfering with each other
    @RiedleroD
    RiedleroD committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    bdfecb6 View commit details
    Browse the repository at this point in the history

  2. fixed flattened wave caused by inaccurate math 

    see PR for before/after
    @RiedleroD
    RiedleroD committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    18b0e8c View commit details
    Browse the repository at this point in the history

  3. simply stop drawing AFP waveform when there's no more data 

    this fixes the single point at the end of waveforms that sometimes shows up
    @RiedleroD
    RiedleroD committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d108c48 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. fixed seemingly insignificant type confusion (?) 

    execution seemed fine but my debugger started freaking out,
and if gdb is telling me I got a negative-sized vector,
I'd rather fix this issue than speculate "it's probably fine"
    @RiedleroD
    RiedleroD committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a13faa2 View commit details
    Browse the repository at this point in the history

  2. fixed data offset for AFP waveform vis 

    the data itself isn't reversed, so we have to account for that
    @RiedleroD
    RiedleroD committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2b7a3bf View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. removed redundant cast

    @RiedleroD
    RiedleroD committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    c66a641 View commit details
    Browse the repository at this point in the history

  2. renamed tmp var to adhere to naming conventions

    @RiedleroD
    RiedleroD committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    a578d03 View commit details
    Browse the repository at this point in the history