fix nullptr deref in AudioFileProcessor (qt6 branch) #7532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiedleroD
changed the title
|
it seems like the docs on running tests are outdated - took me a bit to figure those out. In any case, everything looks fine to me. |
Rossmaxx
reviewed
Oct 4, 2024
Rossmaxx
reviewed
Oct 4, 2024
|
Btw saw it just now that this is against qt6. Any chance this might go on master too? |
Only once qt6 support gets merged. The bug it fixes only occurs because of the |
michaelgregorius
requested changes
Oct 4, 2024
extract check to pointerCloseToStartEndOrLoop()
michaelgregorius
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opening AFP was consistently crashing LMMS on the qt6 branch before - this patch checks whether the passed event pointer is a nullptr, and only derefs it if not.