Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing statics and dead code identified with -Wmissing-declarations #481

Merged
merged 5 commits into from
May 17, 2024
Merged

Fix missing statics and dead code identified with -Wmissing-declarations #481

merged 5 commits into from
May 17, 2024

Conversation

Steven-Roberts
Copy link
Collaborator

No description provided.

gardner48
gardner48 requested changes May 16, 2024
View reviewed changes
src/arkode/arkode_sprk.c Outdated Show resolved Hide resolved
src/sundials/sundials_adaptcontroller.c Outdated Show resolved Hide resolved
src/nvector/manyvector/nvector_manyvector.c Outdated Show resolved Hide resolved
@gardner48 gardner48 mentioned this pull request May 16, 2024
Merged
drreynolds
drreynolds previously requested changes May 16, 2024
View reviewed changes
src/sundials/sundials_adaptcontroller.c Outdated Show resolved Hide resolved
src/sundials/sundials_band.c Outdated Show resolved Hide resolved
gardner48
gardner48 requested changes May 16, 2024
View reviewed changes
Copy link
Member

@gardner48 gardner48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of documentation needed, otherwise this looks good to me

include/sundials/sundials_adaptcontroller.h Show resolved Hide resolved
@gardner48 gardner48 marked this pull request as ready for review May 17, 2024 03:22
@gardner48 gardner48 dismissed drreynolds’s stale review May 17, 2024 03:24

Comments addressed

@gardner48 gardner48 merged commit 48bbc24 into develop May 17, 2024
21 checks passed
@gardner48 gardner48 deleted the bugfix/missing-declarations branch May 17, 2024 12:54
@balos1 balos1 added this to the SUNDIALS Next milestone May 20, 2024
balos1 pushed a commit that referenced this pull request May 20, 2024
@gardner48
CI: Update Compiler Warnings, Enable Warnings as Errors (#484)
aee81f8 
* Additional warning flags from #481, #482, and #483
* Remove `-Wno-deprecated-declarations`
* Enable warnings as errors in GitHub actions
gardner48 added a commit that referenced this pull request Jun 20, 2024
@Steven-Roberts @gardner48 @balos1
Fix missing statics and dead code identified with -Wmissing-declarati…
cbbaca3 
…ons (#481)

Co-authored-by: David Gardner <[email protected]>
Co-authored-by: Cody Balos <[email protected]>
gardner48 added a commit that referenced this pull request Jun 20, 2024
@gardner48
CI: Update Compiler Warnings, Enable Warnings as Errors (#484)
9682816 
* Additional warning flags from #481, #482, and #483
* Remove `-Wno-deprecated-declarations`
* Enable warnings as errors in GitHub actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardner48 gardner48 gardner48 approved these changes

@drreynolds drreynolds drreynolds left review comments

@balos1 balos1 Awaiting requested review from balos1 balos1 is a code owner

@cswoodward cswoodward Awaiting requested review from cswoodward cswoodward is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
SUNDIALS 7.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Steven-Roberts @drreynolds @gardner48 @balos1