Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale fixed #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tsingcoo
Copy link

@tsingcoo tsingcoo commented Nov 2, 2017

The output should be divided by sqrt num_units, but multiplied in your code.

@weitaizhang
Copy link

if you read the paper again , you will find the paper suggests multiply sqrt num_units by embedding weights in embedding layer.
the division happens in multi-attention layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants