Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise: MiniMessageTranslator #972 #1089

Closed

Conversation

KKW557
Copy link

@KKW557 KKW557 commented Jul 2, 2024

This PR is based on the original PR #972 . The original PR was not merged due to several review comments, and the original author is no longer making updates. To continue the development and integration of this feature, I have revised and improved the initial submission.

Copy link
Contributor

@powercasgamer powercasgamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really see a point in this? Besides the fact that the other PR is still marked as a draft, Kezz should be marked as the main author and you as a co author at least.

@KKW557
Copy link
Author

KKW557 commented Jul 2, 2024

I don't really see a point in this? Besides the fact that the other PR is still marked as a draft, Kezz should be marked as the main author and you as a co author at least.

His activities have been gone for three months, and I'm not the author or co author, I think the feature is good but it hasn't been changed in a long time

@masmc05
Copy link

masmc05 commented Jul 2, 2024

There should be a reason why he didn't finish or why he didn't mark the pr as ready, and the author is active, just not on that pr.

Be patient

@kezz
Copy link
Member

kezz commented Jul 2, 2024

The original PR is waiting on virtual components for named arguments (i.e. <name> instead of <arg:1>).

@kezz kezz closed this Jul 2, 2024
@KKW557 KKW557 deleted the feature/minimessage-translator branch July 2, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants