Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CEL Interperter for Conditions #354

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

CEL Interperter for Conditions #354

wants to merge 12 commits into from

Commits on Jun 5, 2024

  1. Quick and dirty CEL support

    @alexsnaps @chirino
    alexsnaps authored and chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    9801078 View commit details
    Browse the repository at this point in the history

  2. Bring back the original simple parsing, and only enable cel expressio… 

    …n parsing if the condition has the `cel:` prefix.

Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    5007c15 View commit details
    Browse the repository at this point in the history

  3. Don’t change the simple key encoding so that redis keys don’t change.

    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c063001 View commit details
    Browse the repository at this point in the history

  4. Drop dead code, and cargo fmt. 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c8ad128 View commit details
    Browse the repository at this point in the history

  5. Add feature cel_conditions feature flag. 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d42e6d2 View commit details
    Browse the repository at this point in the history

  6. Fix clippy warnings. 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    ff6d4ce View commit details
    Browse the repository at this point in the history

  7. Add more cel tests, handle cases where the var variable name conflict… 

    …s with cel built in expressions.

Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    954485f View commit details
    Browse the repository at this point in the history

  8. Use an assert_false! Macro for better test readability 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    bb0278e View commit details
    Browse the repository at this point in the history

  9. cel: reserve _* identifiers for future internal use like adding 

    helper functions.

Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4f70031 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Pickup updates cel 0.7.0 (patched) version. 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    4ab013f View commit details
    Browse the repository at this point in the history

  2. Improve assert_false! Macro. 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    93795b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Show an alternative way to access the cel variable. 

    Signed-off-by: Hiram Chirino <[email protected]>
    @chirino
    chirino committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    45958e0 View commit details
    Browse the repository at this point in the history