Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: release #98

Merged
merged 1 commit into from
Jul 18, 2024
Merged

doc: release #98

merged 1 commit into from
Jul 18, 2024

Conversation

eguzki
Copy link
Collaborator

@eguzki eguzki commented Jun 28, 2024

No description provided.

@eguzki eguzki requested a review from a team June 28, 2024 09:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.66%. Comparing base (7296e1b) to head (b00f255).
Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #98       +/-   ##
==========================================
+ Coverage   0.38%   58.66%   +58.27%     
==========================================
  Files         17       17               
  Lines        783      612      -171     
==========================================
+ Hits           3      359      +356     
+ Misses       780      181      -599     
- Partials       0       72       +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


* Pick recently pushed git tag
* Automatically generate release notes from previous released tag
* Set as the latest release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small thing, but I guess you could do the verify bits at #45, then set it as latest release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those verify steps, should not be some integration tests automated?

We could have a workflow triggered on tagging that run those tests. Then the documentation explains that before creating the GH release, we should check the result of those tests.

how does it sound?

@eguzki eguzki merged commit 2bc1faf into main Jul 18, 2024
5 checks passed
@eguzki eguzki deleted the release-doc branch July 18, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants