Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose description of git hook configuration #913

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Verbose description of git hook configuration #913

wants to merge 1 commit into from

Conversation

mpasternak
Copy link

Fixes #876 . Kind of :-)

This was referenced Dec 31, 2018
Closed
Open
@mpasternak
Copy link
Author

Please also see pull request #914

@mookie- mookie- mentioned this pull request Jan 9, 2019
Closed
@mookie-
Copy link
Contributor

mookie- commented Jan 9, 2019

@mpasternak I think it could be good to mention to check the owner of the .git directory afterwards. But it's just a thought, not important.

@Unrud Unrud force-pushed the master branch 3 times, most recently from 767d614 to 41bccb2 Compare August 31, 2020 12:14
@jan-krieg jan-krieg mentioned this pull request Jul 1, 2023
Open
pbiering
pbiering approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pbiering pbiering self-assigned this Mar 1, 2024
@pbiering
Copy link
Collaborator

pbiering commented Mar 1, 2024

part of this is already documented in DOCUMENTATION.md, please create a PR for this, config is not the right place for extended documentation.

@pbiering pbiering added the need:reporter feedback feedback from reporter required label Mar 1, 2024
pbiering
pbiering requested changes Mar 1, 2024
View reviewed changes
Copy link
Collaborator

@pbiering pbiering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please request PR for DOCUMENTATION.md

@pbiering pbiering added the need:rebase pull request cannot be applied before rebased label Jun 11, 2024
@pbiering
Copy link
Collaborator

@mpasternak : can you please review whether this PR is still needed, if so, please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbiering pbiering pbiering requested changes

Assignees

@pbiering pbiering

Labels
documentation need:rebase pull request cannot be applied before rebased need:reporter feedback feedback from reporter required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default git hook does not work out of the box
3 participants
@mpasternak @mookie- @pbiering