Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the order of atomicfu and kotlin plugins in the classpath #3984

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Change the order of atomicfu and kotlin plugins in the classpath #3984

merged 3 commits into from
Dec 14, 2023

Commits on Dec 12, 2023

  1. This commit changes the order of adding atomicfu and kotlin gradle pl… 

    …ugin to the classpath.

 in the global buildscript: when atomicfu-gradle-plugin is not added to the classpath first, it is not applied at all.
 When kotlin-gradle-plugin is added first, atomicfu-gradle-plugin is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph".

This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377).

The problem was revealed while running a train build against kotlin-community/dev branches before kotlinx-atomicfu 0.23.2.
    @mvicsokolova
    mvicsokolova committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    3f7a181 View commit details
    Browse the repository at this point in the history

  2. The comment

    @mvicsokolova
    mvicsokolova committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c6506e0 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Link to the atomicfu issue

    @mvicsokolova
    mvicsokolova committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    66f0989 View commit details
    Browse the repository at this point in the history