Introduce @Rpc annotation #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
All modules
Problem Description
Starting from Kotlin
2.0.20Compiler FIR plugins and unable to resolve marker interfaces.This prevents us from upgrading to newer versions.
Related issue: https://youtrack.jetbrains.com/issue/KT-72654/
Solution
To resolve services we now need an annotation, namely
@Rpc.However, this makes two similar names:
RPCfor interface andRpcfor annotation.So
RPCis now changed toRemoteService. It will be with us while no better name is found.