Tidy up our synchronization code #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er working and maintenance
fzhinkin
approved these changes
Mar 22, 2024
| * The problem is, commonizer cannot commonize pthreads, thus this declaration should be duplicated | ||
| * over multiple Native source-sets to work properly | ||
| */ | ||
| //public class NativeMutexNode { |
There was a problem hiding this comment.
Do you expect commonizer being able to unlock this implementation one day? Do we really need to keep it here?
There was a problem hiding this comment.
This, or that we'll decide to give up on the commonizer and just copy-paste it over a few native sourcesets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for #412 to simplify further development and maintenance
The current state:
CPointers?)Further step:
optimize-synchronized)