Apply atomicfu compiler plugin directly in buildscript classpath. #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Atomicfu compiler plugin should be manually added to the classpath by the user, otherwise the error is thrown by the plugin * All kotlin-stdlib transitive dependencies are removed This commit is part of the solution to the problem described in #370
mvicsokolova
force-pushed
the
remove-transitive-stdlib-dependency
branch
from
d0179bd
to
53de063
Compare
|
Here I also suggest to remove old atomicfu-gradle-plugin tests 👀: #378 |
fzhinkin
reviewed
Dec 7, 2023
atomicfu-gradle-plugin/src/main/kotlin/kotlinx/atomicfu/plugin/gradle/AtomicFUGradlePlugin.kt
Show resolved
Hide resolved
|
I've added a separate commit with removal of old atomicfu-gradle-plugin tests to these changes.
|
…n version in the project
shanshin
approved these changes
Dec 7, 2023
| @@ -1,10 +1,14 @@ | |||
| buildscript { | |||
| repositories { | |||
| mavenLocal() | |||
There was a problem hiding this comment.
It seems to me that in the future it is better to use custom repositories for functional tests, rather than mavenLocal()
There was a problem hiding this comment.
- I've added that to the ticket: Further enhancements of integration testing #362
fzhinkin
approved these changes
Dec 7, 2023
mvicsokolova
added a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Dec 11, 2023
…ript: when atomicfu-gradle-plugin is not added to the classpath first, it is not applied at all. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). The problem was revealed while running a train build before kotlinx-atomicfu 0.23.2 release.
mvicsokolova
added a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Dec 11, 2023
…ript: when atomicfu-gradle-plugin is not added to the classpath first, it is not applied at all. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). The problem was revealed while running a train build before kotlinx-atomicfu 0.23.2 release. The coroutines build failed with error: "e: Module kotlinx.atomicfu cannot be found in the module graph".
woainikk
pushed a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Dec 12, 2023
…ript: when atomicfu-gradle-plugin is not added to the classpath first, it is not applied at all. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). The problem was revealed while running a train build before kotlinx-atomicfu 0.23.2 release.
mvicsokolova
added a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Dec 12, 2023
…ugin to the classpath. in the global buildscript: when atomicfu-gradle-plugin is not added to the classpath first, it is not applied at all. When kotlin-gradle-plugin is added first, atomicfu-gradle-plugin is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). The problem was revealed while running a train build against kotlin-community/dev branches before kotlinx-atomicfu 0.23.2.
mvicsokolova
added a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Dec 12, 2023
…ugin to the classpath. in the global buildscript: when atomicfu-gradle-plugin is not added to the classpath first, it is not applied at all. When kotlin-gradle-plugin is added first, atomicfu-gradle-plugin is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). The problem was revealed while running a train build against kotlin-community/dev branches before kotlinx-atomicfu 0.23.2.
This was referenced Dec 12, 2023
Merged
mvicsokolova
added a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Dec 14, 2023
This commit changes the order of adding atomicfu and kotlin gradle plugin to the classpath. When `kotlin-gradle-plugin` is added first, `atomicfu-gradle-plugin` is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". The change of order fixes the issue. Should be properly investigated. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). Here is the corresponding issue in atomicfu: Kotlin/kotlinx-atomicfu#384
woainikk
pushed a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Jan 4, 2024
This commit changes the order of adding atomicfu and kotlin gradle plugin to the classpath. When `kotlin-gradle-plugin` is added first, `atomicfu-gradle-plugin` is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". The change of order fixes the issue. Should be properly investigated. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). Here is the corresponding issue in atomicfu: Kotlin/kotlinx-atomicfu#384 (cherry picked from commit 605ec56)
woainikk
pushed a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Jan 4, 2024
This commit changes the order of adding atomicfu and kotlin gradle plugin to the classpath. When `kotlin-gradle-plugin` is added first, `atomicfu-gradle-plugin` is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". The change of order fixes the issue. Should be properly investigated. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). Here is the corresponding issue in atomicfu: Kotlin/kotlinx-atomicfu#384 (cherry picked from commit 605ec56)
woainikk
pushed a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Jan 9, 2024
This commit changes the order of adding atomicfu and kotlin gradle plugin to the classpath. When `kotlin-gradle-plugin` is added first, `atomicfu-gradle-plugin` is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". The change of order fixes the issue. Should be properly investigated. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). Here is the corresponding issue in atomicfu: Kotlin/kotlinx-atomicfu#384 (cherry picked from commit 605ec56)
woainikk
pushed a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Jan 9, 2024
This commit changes the order of adding atomicfu and kotlin gradle plugin to the classpath. When `kotlin-gradle-plugin` is added first, `atomicfu-gradle-plugin` is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". The change of order fixes the issue. Should be properly investigated. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). Here is the corresponding issue in atomicfu: Kotlin/kotlinx-atomicfu#384 (cherry picked from commit 605ec56)
mvicsokolova
added a commit
that referenced
this pull request
Jan 15, 2024
…ject (#386) * Do not require to add atomicfu compiler plugin dependency manually to the buildscript of the project. This change reverts #377. To prevent resolution conflicts of the compiler plugin version, atomicfu-gradle-plugin adds dependency to the earliest plugin version 1.6.20 and gradle should resolve it to the newest version present in the classpath of the user project. Fixes #384 * Old atomicfu-gradle-plugin tests: remove tasks that used to log classpath of the plugin for atomicfu-gradle-plugin tests, as those tests are already removed. * Resolved the warning for compileOnly dependency to kotlin-stdlib present in Native sourceSets. kotlin-stdlib dependency is added as an implementation dependency now, though it's version is marked as prefered to avoid resolution in the user project.
woainikk
pushed a commit
to Kotlin/kotlinx.coroutines
that referenced
this pull request
Jan 18, 2024
This commit changes the order of adding atomicfu and kotlin gradle plugin to the classpath. When `kotlin-gradle-plugin` is added first, `atomicfu-gradle-plugin` is not applied at all and this error is thrown: "e: Module kotlinx.atomicfu cannot be found in the module graph". The change of order fixes the issue. Should be properly investigated. This behaviour started to reproduce after this change in kotlinx-atomicfu (Kotlin/kotlinx-atomicfu#377). Here is the corresponding issue in atomicfu: Kotlin/kotlinx-atomicfu#384 (cherry picked from commit 605ec56)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is part of the solution to the problem described in #370