Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented custom SQL DB registration #917

Merged
merged 9 commits into from
Nov 6, 2024
+249 −73
Merged

Implemented custom SQL DB registration #917

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b5e755b
Add optional dbType parameter to JDBC read functions
zaleslaw Sep 17, 2024
2986f90
Add support for custom DB types in schema generation
zaleslaw Sep 18, 2024
33dd6d7
Refactor database type handling with ServiceLoader
zaleslaw Sep 20, 2024
9b5ef51
Merge branch 'master' into zaleslaw/customdb
zaleslaw Oct 10, 2024
1a67117
Reverted support custom DB for plugins
zaleslaw Oct 10, 2024
d29b609
Added tests for customDB for limited number of cases and API testing
zaleslaw Oct 10, 2024
a170703
Add dbType parameter to readSqlTable function
zaleslaw Oct 14, 2024
0694401
Merge branch 'master' into zaleslaw/customdb
zaleslaw Nov 6, 2024
d7a30f8
Update Javadoc to clarify automatic database type recognition
zaleslaw Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dataframe-jdbc/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/db/H2.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import kotlin.reflect.KType
*
* NOTE: All date and timestamp-related types are converted to String to avoid java.sql.* types.
*/
public class H2(public val dialect: DbType = MySql) : DbType("h2") {
public open class H2(public val dialect: DbType = MySql) : DbType("h2") {
init {
require(dialect::class != H2::class) { "H2 database could not be specified with H2 dialect!" }
}
Expand Down
Loading
Loading