Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GeneratedField.kt #880

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

GeorgCantor
Copy link
Contributor

Helper Function: The toNotNullableName() extension function encapsulates the logic for determining how to transform a markerName or typeFqName. This reduces code duplication across the different field types.

Readability: By using a helper function, we make it clear what transformation is being applied to the names, improving overall readability.

Maintainability: If the logic for determining how to handle names changes in the future, you only need to update it in one place.

@Jolanrensen
Copy link
Collaborator

Hi! Thanks for your small refactor.

For this PR it seems like you edited the generated-sources directory instead of the src one. The generated sources are, as the name suggests, auto-generated based on the sources. This means that editing them will do nothing as they will be overwritten when pushed to master.

I would like to point you to our contribution guide which describes how to contribute, run tests, the kdocs preprocessor etc.

For now, if you edit src instead, I'll approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants