Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle no audio #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ryanontheinside
Copy link

when no audio is extracted, return silence

when no audio is extracted return silence
@AustinMroz
Copy link
Collaborator

AustinMroz commented Jul 30, 2024

Thanks for for taking the time to open a pull request.

The not yet merged commit 9405e80 adds an alternative fix which, compared to the one here

  • Doesn't create a -audio output file when no audio is extracted
  • Still raises an error if that error is used on a different node that requires audio (Such as a VAEEncodeAudio for a StableAudio workflow).
  • Immediately errors if the audio was loaded by a Load Audio node where audio is explicity desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants