-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): ca and certs are not included in loading db from CLI #8111
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this just a plumbing PR or is there a case that works now that didn't before? The word fix implies something wasn't working before, if that is the case there probably could be a test case to show what it was.
Let me take a look and cover it, originally it was a quick fix but as more changes will be introduced, setting it to draft. |
Added tests with fake db, certs. The cert test will load the fake cert although it will finally fail, which should be ok. |
@@ -0,0 +1 @@ | |||
fake key content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a future PR pass I recommend we also try with a working cert
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 originally I added one but the key was blamed by the github bot above, probably we could try with cert. 🥹
console.log(result); | ||
} | ||
expect(result.stdout).toContain('Adding SSL PEM certificate'); | ||
expect(result.stdout).toContain('Adding SSL KEY certificate'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Changes
Ref: INS-4598