Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate #3

Open
wants to merge 174 commits into
base: main
Choose a base branch
from
Open

Release candidate #3

wants to merge 174 commits into from

Conversation

Alrighttt
Copy link
Member

@Alrighttt Alrighttt commented Oct 2, 2024

To do:

  • incorporate and security review types: Switch to fixed-length PolicyHash preimage SiaFoundation/core#207 ref

  • implement methods in V2TransactionBuilder for atomic swap signing. Requires impl SatisfyPolicy for AtomicSwap ref

  • Generic error handling in the dispatcher. Current error handling still has remnants of now refactored dispatcher. ref

  • Move the example client to a rust doc example

  • Wrap all relevant unit tests with cross_target_tests example

  • Migrate docker test framework from Komodo DeFi Framework into Sia Rust. There are tests throughout the codebase that rely on a hardcoded URL to a walletd index node. Remove these in favor of mocked API or walletd docker containers.

  • Implement the remaining file contract related types for V2Transaction. This is not critical for final delivery as we can safely ignore this data in deserialization and will never do serialization. At a minimum, replace todo!()s with error handling or empty data. ref1 ref2

@mariocynicys
Copy link
Collaborator

Grabbed task 6: Migrate docker test framework from Komodo DeFi Framework into Sia Rust. There are tests throughout the codebase that rely on a hardcoded URL to a walletd index node. Remove these in favor of mocked API or walletd docker containers.

impl TryFrom<&[u8]> for Preimage and From<Preimage> for Vec<u8>
Add SiacoinOutputId::new

impl Encodable for SiacoinOutputId

derive From, Into for SiacoinOutputId instead of explicit impl
…r Hash256`; Use from_str instead.

add unit test test_siacoin_output_id_new

derive Default for Preimage and fix related tests
Indexing via tx.siacoin_outputs[vout_index] may be a common pattern. WASM usize is u32 which would require doing lossy u64->u32
change Currency::DUST to 1 hasting
…ent_outputs instead of converting to/from u128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants