Adding support for AsyncAws #639
Conversation
| $this->service->createBucket([ | ||
| 'Bucket' => $this->bucket, | ||
| ]); | ||
| $this->bucketExists = true; |
There was a problem hiding this comment.
we could wait until the bucket exists here
|
Friendly ping for @nicolasmure and @nm2107 Do you need help maintaining Gaufrette and GaufretteBundle? |
|
Hello @Nyholm, |
|
Sure. Thank you. |
|
Done, don't hesitate to ping me for help or assign me code reviews, I'll do my best to be reactive 😉 Thanks for your help! |
|
Thank you. I've made sure master is green and supports PHP7.4. I've also added some tests on github actions. I removed some deprecated code. There is no point in keeping that around for long. I'll merge this and |
| */ | ||
| public function __construct(SimpleS3Client $service, $bucket, array $options = [], $detectContentType = false) | ||
| { | ||
| if (!class_exists(SimpleS3Client::class)) { |
There was a problem hiding this comment.
this check is useless. If the class does not exist, it is impossible to pass an argument to $service due to the typehint. So this is dead code.
There was a problem hiding this comment.
That is true.
Thank you
This will fix #638