Nd2 camera transform #803
Open
Nd2 camera transform #803
+84
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are notes on how to do the general affine transform, but this currently composites less well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added typescript definitions to handle the transformation matrix.
I also changed the logic a little bit. Instead of just inverting the position, I rounded the transformation matrix to a straight inversion. This inverted the entire image (although still aligned). I stuck with rounding the transformation matrix because then it will more closely match what would happen of the transformation matrix was actually applied.
I still don't have an example of an image with more interesting transformation values to fully test out the code, but I think it is a strict improvement from what was there before.