Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement basic build measurements UI #2501

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

williamjallen
Copy link
Collaborator

This PR adds the ability to view the build measurements data added to the API in #2460. The infrastructure needed to send data in CDash hasn't been completed yet, so this page doesn't currently have any data to display, and can't be navigated to in the UI. Once the necessary infrastructure is in place, I plan to open a separate PR to add links to this page throughout the UI.

A screenshot of the page with artificial data for reference:
image

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look good, both the graphql and the UI return fake data stuffed into the database.

I have an issue with the column/filter value mismatch, again, where the Name field is really capturing the title of the column and Value is an entry in that column. @williamjallen, is this intentional?

@williamjallen
Copy link
Collaborator Author

Note: We talked about this in person and will let this sit until the backend data submission process is finished while we ponder the UI design.

@williamjallen williamjallen marked this pull request as draft October 15, 2024 17:12
@bartlettroscoe
Copy link

@williamjallen, can we differentiate the type of target:

  • object
  • library
  • executable
  • custom (i.e. added with add_custom_command())
  • other (everything else)

?

Also, can this also display the labels associated with each target and provide a way to filter based on the labels? (I think we can use CMake target labels to differentiate library targets/code from test targets/code.)

I will add that to the wish-list.

@williamjallen
Copy link
Collaborator Author

@bartlettroscoe Yes, there will be a field which contains information what type of command was run. Currently the placeholder value is "TARGET", but that will change once we agree on the final design of the CTest-CDash interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants