Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CU-86bze09vt Move vectorizing to new clusters #53

Merged
merged 7 commits into from
Aug 22, 2024
Merged

CU-86bze09vt Move vectorizing to new clusters #53

merged 7 commits into from
Aug 22, 2024

Conversation

bhvishal9
Copy link
Collaborator

@bhvishal9 bhvishal9 commented Aug 20, 2024 •
edited
Loading

Description:

The PR moves the app deployment to the new clusters.

This PR includes:

  • A .dockerignore file to ignore unnecessary files in docker
  • Removal of AWS access keys and secret access keys
  • Moves the workflows to new structure with ECR and Argo, also uses an IAM role with federated access for the workflow tests which are failing currently and should be fixed with someone who has more expertise with this project
  • Improves the dockerfile
  • Updates boto3 to the current latest version to support AWS EKS pod identity.

Demo:

  • Already running on staging with https://vectorizing.stagingdesigner.com

Checklist (based on PR guidelines):

  • I have self-reviewed this PR, according to these points
  • This PR falls into maximum three of these categories
  • I feel comfortable taking responsibility for merging this code to production
  • The code is high quality, well-tested, follows styles guides (Frontend), clean, and well documented

@bhvishal9 bhvishal9 force-pushed the CU-86bze09vt-move-to-new-clusters branch 7 times, most recently from 570875f to 4f4d9c2 Compare August 20, 2024 14:15
@bhvishal9 bhvishal9 force-pushed the CU-86bze09vt-move-to-new-clusters branch 2 times, most recently from 9dfcd49 to 8da07dc Compare August 21, 2024 10:42
@bhvishal9 bhvishal9 force-pushed the CU-86bze09vt-move-to-new-clusters branch from 8da07dc to cb8f4ca Compare August 21, 2024 10:42
@bhvishal9 bhvishal9 marked this pull request as ready for review August 22, 2024 12:36
pietrobolcato
pietrobolcato approved these changes Aug 22, 2024
View reviewed changes
Copy link
Collaborator

@pietrobolcato pietrobolcato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚀

@bhvishal9 bhvishal9 merged commit e74b781 into main Aug 22, 2024
0 of 2 checks passed
@bhvishal9 bhvishal9 deleted the CU-86bze09vt-move-to-new-clusters branch August 22, 2024 12:47
bhvishal9 added a commit that referenced this pull request Aug 23, 2024
@bhvishal9 @pietrobolcato
Deploy to production 2024-08-22 / 1 (#54)
419e920 
* Add CI to vectorizing CU-86bvyavpu  (#46)

* Add CI pipeline to run tests with gha
* Add system dependencies installer script shared between dev container and CI
* Update README documentation
* Remove 'python-dev0 as system dependency

* Upgrade vectorizing to python 3.11 CU-866aw6ung (#42)

* Update dockerfile
* Update requirements
* Update environments

* Add linting and formatting CU-86bw0yqjw  (#47)

* Linting and formatting setup using pre-commit
* Updated devcontainer with pre-commit

* Fix k8s deployment CU-86bwkb51r

* Add PR template CU-86bx2ntyx  (#50)

* Add PR template to the repository, with information aligned with guidelines in notion

* Remove PR template to use org one (#51)

* Remove PR template to use org one

* Fix UA  (#52)

* Update UA

* CU-86bze09vt Move vectorizing to new clusters (#53)

* Update Dockerfile and remove AWS AK/SAK

* Update deployment workflow

* Minor modification to the deploy workflow

* Add region_name to the client

* Upgrade boto3

* Update port

* Undo temp changes

---------

Co-authored-by: Pietro Bolcato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietrobolcato pietrobolcato pietrobolcato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhvishal9 @pietrobolcato