-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Upgrade to Avalonia 11.0 + add Browser project #645
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,711 @@ | |||
using System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this PR has lots of changes as I had to rename this file, so it can be reused in environments without windows (browser).
public static void WriteToXml(Build build, Stream stream) | ||
{ | ||
var writer = new XmlLogWriter(); | ||
writer.Write(build, stream); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally these APIs should use async stream reads and writes. As Browser doesn't support sync IO access.
I was able to work around this by coping files content from and to MemoryStream, but it potentially can be a problem with huge binlog files.
I didn't have time to maintain the Avalonia part, so thanks a lot of giving it a refresh! Much appreciated. Don't worry about the changes to the Avalonia version, and let me know if you need to change something in Core or the logger projects. The Windows (WPF) half has more features that I didn't have time to add to Avalonia and was hoping someone would come along and keep the Avalonia version in sync. Sorry about that. Nothing easier than "walk both versions line by line and see what is missing from Avalonia" comes to mind. Mention me here if you need my help or have questions. |
Oh, and whenever you're happy with the browser version, we can start publishing it at https://avalonia.msbuildlog.com or something (let me know if you can think of a better URL). https://live.msbuildlog.com is already taken by the Blazor version that lives in the |
@maxkatz6 maybe you can wrap this up? I think this is good progress for MsBuildogViewer on Avalonia. |
@kant2002 I am primarily waiting for preview5 to be released + some spare time. There are some breaking changes comparing to preview4, so I want to handle it as early. |
@KirillOsenkov I have done minimal changes what I had planned. Remaining improvements can be done independently later. |
The wasm app is so damn cool! I'd really like to see this make its way to a hosted public site, like a fancier version of https://live.msbuildlog.com/ |
Opening this PR as I thought it should be pretty easy to migrate, but also opens some nice possibilities.
I will push changes to this branch once in a while, updating it with newer Avalonia builds.
What I want to do in this PR
Out of scope, but could be done