Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

New symbol for the 64-pin STM32F405R #280

Merged
merged 6 commits into from
Nov 8, 2015
Merged

Conversation

zeroping
Copy link

This is the 64-pin version of the 100-pin STM32F405's already in the repo. Hopefully it looks OK to everyone.

@odurc
Copy link
Collaborator

odurc commented Sep 9, 2015

Hello @zeroping . Please apply KLC and check your symbol using checklib script.

@zeroping
Copy link
Author

Well, I just got off my duff and used checklib on my version. (It's been over a month.)
Just about all of the parts fail 3.1 and 3.6, even the ones I don't think I modified. Let me go clean this up...

@CarlPoirier
Copy link
Contributor

Hi Scott,

Indeed, not all existing symbols are compliant with the KLC because they
were made before it. We however enforce the KLC on new symbols. If you want
to give us a hand at making the whole library compliant, that would be very
much appreciated!

Well, I just got off my duff and used checklib on my version. (It's been
over a month.)
Just about all of the parts fail 3.1 and 3.6, even the ones I don't think I
modified. Let me go clean this up...


Reply to this email directly or view it on GitHub
#280 (comment).

@zeroping
Copy link
Author

Ok, it's fixed now in my version.

I modified one of the library utils to do this:
KiCad/kicad-library-utils#9

@CarlPoirier
Copy link
Contributor

Hi Scott,

That's awesome! I looked at it and although not perfect, I'll merge it in this state right now because it is much better than before and no rule is violated.

The only thing I think would be left to do is make the pin lengths uniform. There are 100, 150 and 300mils pins depending on the symbols. If they could all be 150mils that would be great.

Thank you for your contribution!

CarlPoirier added a commit that referenced this pull request Nov 8, 2015
New symbol for the 64-pin STM32F405R, apply KLC to whole library
@CarlPoirier CarlPoirier merged commit b6c80fa into KiCad:master Nov 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants