-
Notifications
You must be signed in to change notification settings - Fork 711
Add Kailh Choc low profile kbd switch #2420
base: master
Are you sure you want to change the base?
Conversation
I think I will start with those, since it is just 5 footprints. So far all I could find for documentation were those pictures:
|
I'm not too familiar with the contemporary keyboard industry but I assume your typical off-the-shelf keyboard is not hand-assembled by wage slaves. Meaning if some sort of PnP origin is documented somewhere, that would solve the problem. |
Firstly I want to state that I did not originally create most of these footprints, and though i went through most of them and made some extensive modifications, I assumed the footprint was correctly made according to documentation in the first place. I think they have already been tested in real life, so i did not actually check it though i probably should've anyway. That being said I made an effort to try to find the documentation for review, which i posted in the first PR #2394 Reference for Kailh Choc keyswitches it comes from the official manufacturers site so assume it's the best we got, unless maybe we tried contacting them. You found the documentation for the version 2 of these switches, this should explain some of the discrepancies.
Like I mentioned in the original PR this was intentional as I felt it made sense given the nature of these components.
That is a cutout the component has that is meant for an LED to be mounted behind for retroilumination. this could be added to a documentation layer, but I don't find it necessary.
That is the dimension of the Keycap 1.00u in the keyboard world means 19.05mm this is standard nomenclature, the documentation layers have the keycap represented this is for layout and alignment purposes. such a specific label does not make sense in my eyes given that this footprint fits multiple references, and Kailh Choc is a unique series and is representative enough I feel. |
ups. |
97f8e6a
to
0b1fb68
Compare
I added myself as reviewer. But I doubt I will be able to wrap this up before our move to gitlab. If somebody else wants to take this over, please go ahead. |
0b1fb68
to
f24a55c
Compare
Re-generated footprints with kicad-footprint-generator after fixups. |
Signed-off-by: perigoso <[email protected]>
f24a55c
to
45b63fc
Compare
See #2416 and #2394
This PR Adds Kailh Choc low profile keyboard switch footprints.