Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(AzureAISearch): application can be turned off by not including i… #6

Merged
merged 2 commits into from
Mar 18, 2024
Merged

feat(AzureAISearch): application can be turned off by not including i… #6

merged 2 commits into from
Mar 18, 2024

Conversation

bkapustik
Copy link
Collaborator

No description provided.

@bkapustik
feat(AzureAISearch): application can be turned off by not including i…
0fdc5f8 
…t in the program and does not crash if the nugget is referenced
@seangwright
Copy link
Member

Could you also update the README in this PR and change the list of dependencies to include .NET 8 instead of .NET 6?

@bkapustik
Copy link
Collaborator Author

Could you also update the README in this PR and change the list of dependencies to include .NET 8 instead of .NET 6?

I have updated the .NET version however I am not sure if you want to add something else to README. I do not think it is necessary to add information that the application will not result in an error if you add the NuGet but do not reference the package.

@seangwright
Copy link
Member

Could you also update the README in this PR and change the list of dependencies to include .NET 8 instead of .NET 6?

I have updated the .NET version however I am not sure if you want to add something else to README. I do not think it is necessary to add information that the application will not result in an error if you add the NuGet but do not reference the package.

I just wanted to make sure it's clear in the README this package requires .NET 8, not .NET 6.

@fialafilip fialafilip merged commit 4fcc117 into main Mar 18, 2024
1 check passed
@fialafilip fialafilip deleted the feat/turn-off-aplication-without-removing-nugget branch March 18, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fialafilip fialafilip fialafilip approved these changes

@hesspavel hesspavel Awaiting requested review from hesspavel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkapustik @seangwright @fialafilip