-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add custom-device-pollrates service which allows on-the-fly adding/re… #1
base: main
Are you sure you want to change the base?
Conversation
I haven't gotten around to actually spinning up a Fedora virtual machine to test this PR yet, but here are my thoughts so far: Line 3 from custom-device-pollrates.sh looks like it should be a comment, but the line does not start with a custom-device-pollrates.spec states that the license of the service is GPLv3+. The patch itself is GPLv2-only like the rest of the Linux kernel. I suppose that there is no strict need for the patch and the service to have the same license since the Kernel's GPL does not transcend syscall boundaries, but I feel like putting files with incompatible licenses in the same repository may cause more trouble than it is worth. Could you relicense your contribution to GPLv2 or GPLv2+? The default configuration file custom-device-pollrates.conf contains some uncommented sample directives, which could cause the user's pollrate of some devices to change merely by installing the service. I think that merely installing the service should not cause some arbitrary device's pollrates to suddenly change; the pollrate should only change when the user expressedly requested that change. |
Sure, the license was a mistaken copy-paste when I was creating the spec sheet, and someone in my discord called out the missing line comment as well. On Nobara we ship the DS4/DS5 configs enabled as it's a gaming oriented distro but I agree in general there should be no defaults, I've commented them out in the config and added instructions on usage. I also fixed up a missing dependency on the rpm spec sheet that was causing the post/postun scriptlets to fail. Should be solid now hopefully. |
I just tried building the service on a fresh installation of Fedora Workstation 37, but it doesn't seem to work for me:
|
builds properly here using mock, also builds fine on copr, and the script is definitely there: $ ls |
…moval of devices