Use deep clone so Indexer can handle existing branches #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We haven't had a full successful inflation pass in 2 days.
Cause
There are several pending pull requests at https://github.com/KSP-CKAN/CKAN-meta/pulls, and the Indexer keeps failing to push to them because it doesn't have the current state of their branches after restarting after KSP-CKAN/CKAN#4119 was merged. These attempts somehow overwhelm the container's volume credits, which eventually end up at 0.
See #303 and #315 for previous instances of the same issue for other services (except in those cases they were just failing, not overloading the volume credits and blocking the Scheduler from running).
Changes
Now the Indexer uses a deep clone of CKAN-meta, so the existing branches will be retrieved.