Fix timezone problem in ticket closer #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The ticket closer has thrown this the last 2 days:
Cause
Python throws a runtime exception if time zones aren't handled to its liking. 🐍
datetime.now()doesn't have timezone info associated with it, so by process of eliminationissue.updated_atmust have it. Maybe we updated the GitHub API library recently. 🤷Changes
Now we pass
timezone.utctodatetime.now()so both parts of the comparison will have timezone data.I'll self review this so we can see if it works in tomorrow's run.