Add Aspect to ModAnalyzer to detect patch manager patches #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an aspect to the aspects in the ModAnalyzer class that should detect patch manager patches (*.patch files), and automatically add the config tag, and a dependency on PatchManager
HebaruSan
added
Enhancement
HebaruSan
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Obviously this code change is correct, but I'm going to dig into why the tests are emitting errors now... (This happens regularly; dependencies or Python tools get updated and new errors appear where previously there were none, and we try to keep up with these as new code changes are made so they don't accumulate.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A mod has been released for KSP2,
PatchManager, that uses special files (.patch files) to either patch data in the addressables for the game, and/or add new data to the addressables assets. any KSP2 mod that use files with this extension necessarily depend on this mod, examples beingCommunityResources, orKerbalLifeSupportSystem. So it would make sense for them to be autodetected to addPatchManageras a dependency to the mods via theModAnalyzerclass.Changes
Adds an aspect to the
ModAnalyzerclass that detects *.patch files, and adds theconfigtag (closest tag to match for what patch files are), and adds a dependency onPatchManager