You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an outgrowth of KSP-CKAN/CKAN#2789 (comment). I assume that the initial functionality of the queue-based bot will be identical to NetKAN-bot, so ideas for further improvements should be submitted here for better tracking.
Motivation
Some modules such as KSPInterstellarExtended and Kopernicus-Backport upload multiple releases at once, one per supported game version. Currently the bot only has the ability to crawl the latest release, so intervening releases can be missed.
The SpaceDock web hook currently addresses this for KSPInterstellarExtended; each release triggers inflation as it is uploaded, so uploading multiple releases in quick succession usually allows each one to be indexed. However, this does not help with modules that are hosted outside of SpaceDock.
Suggestion
When the Indexer component receives inflated metadata from its input queue, it should check whether the file for that version already exists. If not, then we may have caught one of these multiple-release events; the same module should then be re-submitted to the Inflator's input queue with the Releases attribute set to 3 or 4 or 5.
Maybe this should be controlled by a netkan property?
x_netkan_check_releases: 5
Note that if we implement this, it should also turn off the auto-epoch feature of KSP-CKAN/CKAN#2824, because the releases are likely to be intentionally out of order.
The text was updated successfully, but these errors were encountered:
This could be straight forward, the scheduler could just use an attribute on the sqs message (we already have a command line flag for this don't we?). If the x_netkan_check_releases exists, set a check_releases flag on the outgoing message and the indexer will take care of firing off an inflation task with the check_releases flag set to true.
This is an outgrowth of KSP-CKAN/CKAN#2789 (comment). I assume that the initial functionality of the queue-based bot will be identical to NetKAN-bot, so ideas for further improvements should be submitted here for better tracking.
Motivation
Some modules such as KSPInterstellarExtended and Kopernicus-Backport upload multiple releases at once, one per supported game version. Currently the bot only has the ability to crawl the latest release, so intervening releases can be missed.
The SpaceDock web hook currently addresses this for KSPInterstellarExtended; each release triggers inflation as it is uploaded, so uploading multiple releases in quick succession usually allows each one to be indexed. However, this does not help with modules that are hosted outside of SpaceDock.
Suggestion
When the Indexer component receives inflated metadata from its input queue, it should check whether the file for that version already exists. If not, then we may have caught one of these multiple-release events; the same module should then be re-submitted to the Inflator's input queue with the Releases attribute set to 3 or 4 or 5.
Maybe this should be controlled by a netkan property?
Note that if we implement this, it should also turn off the auto-epoch feature of KSP-CKAN/CKAN#2824, because the releases are likely to be intentionally out of order.
The text was updated successfully, but these errors were encountered: