Create skip-releases option for NetKAN #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DasSkelett
added
Enhancement
HebaruSan
reviewed
Feb 10, 2020
HebaruSan
reviewed
Feb 10, 2020
HebaruSan
requested changes
Feb 10, 2020
With the --skip-releases <int> option set, NetKAN skips the given number of releases for inflation. This happens in the transformers for all the kref sources, just before the --releases option is applied to take multiple releases. This feature is useful for backfilling old releases of a mod, where you don't want to re-inflate the newer ones just to get to the older ones.
DasSkelett
force-pushed
the
feature/netkan-skip-releases
branch
from
7c74d6f
to
053c487
Compare
HebaruSan
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#2681 gave us the great option to inflate multiple releases with netkan.exe.
But sometimes you don't want to begin with the latest release, for example if the folder structure has changed in the history of the mod, and you have to adjust the netkan file for the older releases. Or if one release is failing inflation and you have to skip it.
I had to deal with both of these cases in KSP-CKAN/CKAN-meta#1786, so I finally decided to implement this feature.
Changes
This PR gives netkan.exe a new commandline option,
--skip-releases <int>.This commandline option is fed into the
TransformOptions, which has a newint? SkipReleasesproperty.It is set with the constructor, the queue handler passes
null.Each kref source transformer now skips the given number of releases, and starting from this index, the number of releases given with
opts.Releasesare taken.This feature may be useful for KSP-CKAN/NetKAN-Infra#5, too.