Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label spacing and alignment, show zero download counts as blank in ConsoleUI #4223

Merged
merged 2 commits into from
Oct 5, 2024
Merged

Label spacing and alignment, show zero download counts as blank in ConsoleUI #4223

merged 2 commits into from
Oct 5, 2024

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Oct 5, 2024 •
edited
Loading

Motivations

  • I saw a screenshot of ConsoleUI recently where the new mod-abstract label from 0fae2a2 was overlapping the "updated X days ago" label
  • The "updated X days ago" label is left aligned and wider than it needs to be
  • While working on the above, I noticed that the download counts from Add downloads column for ConsoleUI #4063 for the DLCs were being shown as 0, which doesn't make sense

image

Changes

  • Now the abstract label stops where the "updated X days ago" label starts so they won't overlap
  • Now the "updated X days ago" label's size fits its content with a little padding, and it's right-aligned
  • Now 0 download counts are left blank instead

@HebaruSan HebaruSan added Bug Something is not working as intended Enhancement New features or functionality Easy This is easy to fix ConsoleUI Issues affecting the interactive console UI labels Oct 5, 2024
@HebaruSan HebaruSan changed the title Show zero download counts as blank in ConsoleUI Label spacing and alignment, show zero download counts as blank in ConsoleUI Oct 5, 2024
@HebaruSan HebaruSan merged commit 8c8a2d0 into KSP-CKAN:master Oct 5, 2024
3 checks passed
@HebaruSan HebaruSan deleted the fix/consoleui-label-layout branch October 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something is not working as intended ConsoleUI Issues affecting the interactive console UI Easy This is easy to fix Enhancement New features or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@HebaruSan